Add TPT support to model building, migrations and update pipeline #20938
+6,051
−2,038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
May 13, 2020
src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
bricelam
reviewed
May 13, 2020
| @@ -914,21 +907,23 @@ private static bool EntityTypePathEquals(IEntityType source, IEntityType target, | |||
| return true; | |||
| } | |||
|
|
|||
| if (!string.Equals(source.Name, target.Name)) | |||
There was a problem hiding this comment.
Doesn't this break renaming entity types?
There was a problem hiding this comment.
This method is only used for column diffing, so as long as the type is not renamed together with a column everything should work.
There was a problem hiding this comment.
But renaming the type and a column is a scenario we should cover since the PK column (and others) frequently includes the type name
There was a problem hiding this comment.
You would also need to rename a different column to what the PK column was before to hit this
lajones
reviewed
May 13, 2020
src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalForeignKeyExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalForeignKeyExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalModelValidator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Conventions/EntityTypeMappingConvention.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Conventions/SharedTableConvention.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
May 14, 2020
src/EFCore.Relational/Extensions/RelationalPropertyExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Extensions/RelationalPropertyExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Metadata/Conventions/RelationalValueGenerationConvention.cs
Show resolved
Hide resolved
test/EFCore.Relational.Specification.Tests/Query/TPTRelationshipsQueryTestBase.cs
Show resolved
Hide resolved
smitpatel
reviewed
May 15, 2020
src/EFCore.Relational/Extensions/RelationalEntityTypeExtensions.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
May 15, 2020
smitpatel
reviewed
May 15, 2020
test/EFCore.Specification.Tests/Query/NorthwindFunctionsQueryTestBase.cs
Outdated
Show resolved
Hide resolved
|
It would have been better if langword changes happened in a different PR. |
ajcvickers
reviewed
May 15, 2020
|
I feel like somebody attached a "langword" rider to the TPT bill. |
ajcvickers
approved these changes
May 15, 2020
lajones
reviewed
May 22, 2020
src/EFCore.Relational/Metadata/Conventions/EntityTypeHierarchyMappingConvention.cs
Show resolved
Hide resolved
lajones
reviewed
May 22, 2020
lajones
reviewed
May 22, 2020
lajones
reviewed
May 22, 2020
lajones
reviewed
May 22, 2020
lajones
reviewed
May 22, 2020
lajones
reviewed
May 22, 2020
lajones
reviewed
May 22, 2020
lajones
reviewed
May 22, 2020
src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
lajones
reviewed
May 22, 2020
lajones
reviewed
May 22, 2020
lajones
reviewed
May 22, 2020
test/EFCore.Specification.Tests/Query/NorthwindFunctionsQueryTestBase.cs
Outdated
Show resolved
Hide resolved
lajones
approved these changes
May 22, 2020
|
@bricelam Can you take a look at the last commit? |
bricelam
reviewed
May 27, 2020
src/EFCore.Relational/Migrations/Internal/MigrationsModelDiffer.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2266