Fix to #16092 - Query: Simplify case blocks in SQL tree #20966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
commented
May 15, 2020
smitpatel
reviewed
May 15, 2020
|
@smitpatel it's not rly part of null semantics. it needs to happen before null semantics. I can put it in a separate visitor, as mentioned in a comment |
|
Does it need to know parameter values? |
|
updated |
maumar
commented
May 15, 2020
src/EFCore.Relational/Query/Internal/CaseWhenFlatteningExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
force-pushed
the
fix16092
branch
2 times, most recently
from
c643051
to
b134660
Compare
|
updated |
smitpatel
reviewed
May 15, 2020
src/EFCore.Relational/Query/Internal/CaseSimplifyingExpressionVisitor.cs
Show resolved
Hide resolved
|
ping |
smitpatel
reviewed
May 19, 2020
| var matchingCaseBlock = caseComponent.WhenClauses.FirstOrDefault(wc => sqlConstantComponent.Equals(wc.Result)); | ||
| if (matchingCaseBlock != null) | ||
| { | ||
| return matchingCaseBlock.Test; |
There was a problem hiding this comment.
Possibly visit recursively. Also write a regression test for it.
smitpatel
reviewed
May 19, 2020
src/EFCore.Relational/Query/Internal/CaseSimplifyingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
May 19, 2020
src/EFCore.Relational/Query/Internal/CaseSimplifyingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
May 19, 2020
src/EFCore.Relational/Query/Internal/CaseSimplifyingExpressionVisitor.cs
Show resolved
Hide resolved
smitpatel
reviewed
May 19, 2020
src/EFCore.Relational/Query/Internal/CaseSimplifyingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
Adding optimization to during post processing Trying to match CASE block that corresponds to CompareTo translation. If that case block is compared to 0, 1 or -1 we can simplify it to simple comparison. Also added generic CASE block optimization, when constant is compared to CASE block, and that constant is one of the results Fixes #16092
|
@smitpatel updated |
smitpatel
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding optimization to during post processing (null semantics)
Trying to match CASE block that corresponds to CompareTo translation. If that case block is compared to 0, 1 or -1 we can simplify it to simple comparison.
Also added generic CASE block optimization, when constant is compared to CASE block, and that constant is one of the results
Fixes #16092