Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Perform join operations when one of the source has client eval #21201

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

smitpatel
Copy link
Contributor

@smitpatel smitpatel commented Jun 10, 2020

Resolves #19247
Resolves #17763
Lays ground work for #20291
Required for #20892

Base automatically changed from smit/combination to feature/splitInclude June 10, 2020 07:32
@@ -227,10 +241,29 @@ protected override Expression VisitExtension(Expression extensionExpression)

if (extensionExpression is EntityShaperExpression entityShaperExpression)
{
// TODO: Make this easier to understand some day.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimistic

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 🇮🇹

@smitpatel smitpatel merged commit c5ca9ff into feature/splitInclude Jun 11, 2020
@smitpatel smitpatel deleted the smit/clientselectmany branch June 11, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants