Metadata: Bring back SqlServerDbFunctionConvention #21388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/EFCore.SqlServer/Metadata/Conventions/SqlServerConventionSetBuilder.cs
Outdated
Show resolved
Hide resolved
| namespace Microsoft.EntityFrameworkCore.Metadata.Conventions | ||
| { | ||
| /// <summary> | ||
| /// A convention that ensures that <see cref="IDbFunction.Schema"/> is populated for database functions which are not built-in. |
There was a problem hiding this comment.
How do you determine that they are built-in?
There was a problem hiding this comment.
That is coming in #17268 (submitting PR for that once this is approved).
Just future-proof documentation. 😄
There was a problem hiding this comment.
I can improve this in next PR by referring the IsBuiltIn property too.
AndriySvyryd
approved these changes
Jun 23, 2020
smitpatel
force-pushed
the
smit/cannotdecideaname
branch
from
f9c5dc6
to
76e3f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #20182