Query: Rewrite entity equality for dependents sharing table #21747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
smitpatel
commented
Jul 23, 2020
| CreatePropertyAccessExpression(left, p), | ||
| CreatePropertyAccessExpression(right, p))) | ||
| .Aggregate((l, r) => Expression.AndAlso(l, r))); | ||
| { |
There was a problem hiding this comment.
This extends the fix for #19407 for more scenarios.
|
/azp run build macos |
|
No pipelines are associated with this pull request. |
|
/azp run all |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maumar
reviewed
Jul 24, 2020
| @@ -459,7 +459,7 @@ private Expression TryExpandNavigation(Expression root, MemberIdentity memberIde | |||
| return innerSource.PendingSelector; | |||
| } | |||
|
|
|||
| static Expression AddConvertToObject(Expression expression) | |||
| private static Expression AddConvertToObject(Expression expression) | |||
There was a problem hiding this comment.
convert it into local function?
There was a problem hiding this comment.
I thought about it. Initially I intended to write it as a local function and I thought I did. But then VS said, I need to add accessibility modifier and added private in front of it. So I realized it is not local function.
But then
Inside an .Internal class
in a nested clas
in a private method
Does it really matter ? 
maumar
approved these changes
Jul 24, 2020
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20342