Fix FreeText tests #21922
Merged
Fix FreeText tests #21922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #18199
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
maumar
reviewed
Aug 3, 2020
| @@ -225,15 +227,15 @@ public void FreeText_through_navigation_with_language_terms() | |||
| c => EF.Functions.FreeText(c.Manager.Title, "President", 1033) | |||
| && EF.Functions.FreeText(c.Title, "Inside", 1031) | |||
| && c.FirstName.Contains("Lau")) | |||
| .LastOrDefault(); | |||
| .FirstOrDefault(); | |||
There was a problem hiding this comment.
I reckon there is only one matching row in the table, but perhaps we should add orderby instead?
There was a problem hiding this comment.
Isn't the operator irrelevant here?
What we are testing is translate of FreeText function. So I just added a mix rather than using LastOrDefault everywhere.
maumar
reviewed
Aug 3, 2020
| @@ -423,16 +425,16 @@ public void Contains_through_navigation() | |||
| .Where( | |||
| c => EF.Functions.Contains(c.Manager.Title, "President") | |||
| && EF.Functions.Contains(c.Title, "\"Ins*\"")) | |||
| .LastOrDefault(); | |||
| .FirstOrDefault(); | |||
|
|
|||
maumar
approved these changes
Aug 3, 2020
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18199