Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Add Get-Migrations and update "migrations list" to show applied or pending #22109

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Tools: Add Get-Migrations and update "migrations list" to show applied or pending #22109

merged 2 commits into from
Aug 18, 2020

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Aug 18, 2020 •
edited
Loading

Manually verified that this works as expected and is both forward (3.1 tools on 5.0 projects) and backward (5.0 tools on 3.1 projects) compatible.

Resolves #577

@bricelam bricelam requested a review from a team August 18, 2020 04:31
@bricelam bricelam mentioned this pull request Aug 18, 2020
Closed
4 tasks
@bricelam bricelam merged commit b269f8d into dotnet:release/5.0 Aug 18, 2020
@bricelam bricelam deleted the list branch August 18, 2020 16:38
@ajcvickers ajcvickers mentioned this pull request Aug 20, 2020
Closed
Saibamen
Saibamen reviewed Aug 20, 2020
View reviewed changes
src/EFCore.Design/Properties/DesignStrings.resx

<!--
Microsoft ResX Schema
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete trailing whitespaces

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS adds them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually ResXResourceWriter.Generate() that puts them in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it's random comments like this that lead to random ideas like #22156 😁

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bricelam: Could you paste URL for this method? (or repository URL)
Maybe someone could fix this

Copy link
Contributor Author

@bricelam bricelam Aug 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's fixed in .NET Core. lol, good luck getting it patched in .NET Framework.
https://github.com/dotnet/winforms/blob/master/src/System.Windows.Forms/src/System/Resources/ResXResourceWriter.cs

Copy link
Contributor Author

@bricelam bricelam Aug 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yes, it really is in System.Windows.Forms.dll 🤦‍♂️ (I tried to get it moved in dotnet/winforms#1342)

@nicolas-2008 nicolas-2008 mentioned this pull request Jun 25, 2021
Closed
@Devvox93 Devvox93 mentioned this pull request Feb 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd left review comments

@Saibamen Saibamen Saibamen left review comments

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commands: A way to see current Migrations status
5 participants
@bricelam @Saibamen @smitpatel @AndriySvyryd @Psypher9