[5.0] Remove the correct conflicting skip navigation. #22846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue22809
branch
from
da34a48
to
679d880
Compare
smitpatel
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22809
Description
When an ambiguous many-to-many navigation is discovered the code was trying to remove the wrong navigation resulting in an exception.
Customer Impact
This is happening by convention, before any user configuration is applied, so there is no straightforward workaround.
How found
Customer report on daily build.
Test coverage
This PR adds tests for the affected scenario.
Regression?
No.
Risk
Low. The change only affects a new 5.0 feature many-to-many.