Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Data.Sqlite: Add Default Timeout connection string keyword #23091

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Microsoft.Data.Sqlite: Add Default Timeout connection string keyword #23091

merged 2 commits into from
Dec 8, 2020

Conversation

nmichels
Copy link
Contributor

bricelam
bricelam suggested changes Oct 24, 2020
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Microsoft.Data.Sqlite.Core/SqliteConnection.cs Outdated Show resolved Hide resolved
@bricelam bricelam self-assigned this Oct 25, 2020
@bricelam bricelam force-pushed the MicrosoftDataSqliteDefaultTimeout branch from f050841 to fc43d5a Compare December 8, 2020 19:55
bricelam
bricelam approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworked this a bit while rebasing since the underlying code changed in PR #23549

@bricelam bricelam merged commit fc43d5a into dotnet:main Dec 8, 2020
@ajcvickers ajcvickers mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@bricelam bricelam bricelam approved these changes

Assignees

@bricelam bricelam

Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.Data.Sqlite: Add Default Timeout connection string keyword
4 participants
@nmichels @bricelam @smitpatel @ajcvickers