Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite: Use infix GLOB and REGEXP operators #23193

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Nov 5, 2020

Mostly just to be pretentious

@bricelam bricelam requested a review from a team November 5, 2020 00:04
@@ -34,7 +34,7 @@ public virtual async Task Glob(bool async)
AssertSql(
@"SELECT COUNT(*)
FROM ""Customers"" AS ""c""
WHERE glob('*M*', ""c"".""ContactName"")");
WHERE ""c"".""ContactName"" GLOB '*M*'");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@bricelam bricelam marked this pull request as draft March 16, 2021 15:55
bricelam added a commit to bricelam/efcore that referenced this pull request Aug 31, 2022
Introducing SqliteSqlExpressionFactory as discussed in PR dotnet#23193

Fixes dotnet#25027
bricelam added a commit that referenced this pull request Aug 31, 2022
Introducing SqliteSqlExpressionFactory as discussed in PR #23193

Fixes #25027
@bricelam bricelam changed the base branch from bricelam/funcs to main September 27, 2022 21:28
@bricelam bricelam marked this pull request as ready for review September 27, 2022 21:28
@bricelam bricelam requested a review from a team September 27, 2022 21:29
Mostly just to be pretentious
@bricelam bricelam merged commit 99a642b into dotnet:main Nov 30, 2022
@bricelam bricelam deleted the pretentious branch November 30, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants