SQLite: Use infix GLOB and REGEXP operators #23193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
commented
Nov 5, 2020
| @@ -34,7 +34,7 @@ public virtual async Task Glob(bool async) | |||
| AssertSql( | |||
| @"SELECT COUNT(*) | |||
| FROM ""Customers"" AS ""c"" | |||
| WHERE glob('*M*', ""c"".""ContactName"")"); | |||
| WHERE ""c"".""ContactName"" GLOB '*M*'"); | |||
roji
reviewed
Nov 5, 2020
src/EFCore.Sqlite.Core/Query/Internal/SqliteGlobMethodTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Sqlite.Core/Query/Internal/SqliteQuerySqlGenerator.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Nov 5, 2020
smitpatel
reviewed
Nov 5, 2020
src/EFCore.Sqlite.Core/Query/Internal/SqliteGlobMethodTranslator.cs
Outdated
Show resolved
Hide resolved
bricelam
added a commit
to bricelam/efcore
that referenced
this pull request
Aug 31, 2022
Introducing SqliteSqlExpressionFactory as discussed in PR dotnet#23193 Fixes dotnet#25027
bricelam
added a commit
that referenced
this pull request
Aug 31, 2022
bricelam
force-pushed
the
pretentious
branch
from
c10ec5f
to
c17f9bd
Compare
smitpatel
reviewed
Sep 28, 2022
src/EFCore.Sqlite.Core/Query/Internal/SqliteQuerySqlGenerator.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Sep 28, 2022
src/EFCore.Sqlite.Core/Query/SqlExpressions/Internal/SqliteGlobExpression.cs
Outdated
Show resolved
Hide resolved
smitpatel
approved these changes
Oct 17, 2022
Mostly just to be pretentious
bricelam
force-pushed
the
pretentious
branch
from
64993c6
to
99a642b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just to be pretentious