Replace NotImplementedException with NotSupportedException #23502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
reviewed
Nov 27, 2020
roji
reviewed
Nov 27, 2020
roji
reviewed
Nov 27, 2020
roji
approved these changes
Nov 27, 2020
Fixes #20961 > You might choose to throw a NotImplementedException exception in properties or methods in your own types when the that member is still in development and will only later be implemented in production code. In other words, a NotImplementedException exception should be synonymous with "still in development." I left one NotImplementedException in Migration.cs, because it really is there for when the application hasn't implemented Down yet, but tries to do a Down.
ajcvickers
force-pushed
the
WillNeverBeImplementedException
branch
from
2d43b9f
to
97f2d50
Compare
|
@dotnet/efteam Updated based on design meeting discussion. All are NotSupportedExceptions, with messages where it could be helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20961
I left one NotImplementedException in Migration.cs, because it really is there for when the application hasn't implemented Down yet, but tries to do a Down.