EntityTypeConfiguration annotation #23163 #23563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
reviewed
Dec 5, 2020
src/EFCore/Metadata/Conventions/EntityConfigurationEntityTypeAttributeConvention.cs
Show resolved
Hide resolved
…sn't implement IEntityTypeConfiguration
ilmax
reviewed
Dec 7, 2020
| @@ -67,6 +67,7 @@ public virtual ConventionSet CreateConventionSet() | |||
| conventionSet.EntityTypeAddedConventions.Add(new NotMappedEntityTypeAttributeConvention(Dependencies)); | |||
| conventionSet.EntityTypeAddedConventions.Add(new OwnedEntityTypeAttributeConvention(Dependencies)); | |||
| conventionSet.EntityTypeAddedConventions.Add(new KeylessEntityTypeAttributeConvention(Dependencies)); | |||
| conventionSet.EntityTypeAddedConventions.Add(new EntityConfigurationEntityTypeAttributeConvention(Dependencies)); | |||
There was a problem hiding this comment.
question: Does adding this one means this convention will always run making model building slower for everyone? If that's the case, is it worth it making it a pay per play scenario?
There was a problem hiding this comment.
Yes, we'll do it as part of #214
AndriySvyryd
reviewed
Dec 7, 2020
AndriySvyryd
approved these changes
Dec 8, 2020
|
Thanks for your contribution! |
smitpatel
reviewed
Dec 8, 2020
|
|
||
| private object GetEntityBuilderInstance(IConventionEntityType conventionEntityType, Type entityTypeConfiguration) | ||
| { | ||
| Type[] entityTypeArgs = GetEntityTypeArgs(entityTypeConfiguration); |
smitpatel
reviewed
Dec 8, 2020
|
|
||
| Type constructed = entityTypeBuilder.MakeGenericType(entityTypeArgs); | ||
|
|
||
| var entityTypeBuilderInstance = Activator.CreateInstance(constructed, new object[] { conventionEntityType }); |
There was a problem hiding this comment.
Shouldn't we verify some sort of clr type match?
For an entityType of "Blog", we cannot really use IEntityTypeConfiguration<Post>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23163
I am not sure how I have to handle the case when in the attribute a wrong Configuration type is given