Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix build failures in SqlServer ubuntu run #23733

Merged
1 commit merged into from
Dec 19, 2020
Merged

Try to fix build failures in SqlServer ubuntu run #23733

1 commit merged into from
Dec 19, 2020

Conversation

smitpatel
Copy link
Contributor

Sometimes you just need more time

SqlServer functional tests in ubuntu are timing out intermittently by hitting half an hour mark.

Sometimes you just need more time
@ghost
Copy link

ghost commented Dec 19, 2020

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@smitpatel smitpatel requested a review from a team December 19, 2020 00:47
@smitpatel smitpatel changed the title Update helix.proj Try to fix build failures in SqlServer ubuntu run Dec 19, 2020
@ghost
Copy link

ghost commented Dec 19, 2020

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit ca97f03 into main Dec 19, 2020
@ghost ghost deleted the smitpatel-patch-1 branch December 19, 2020 08:22
@ajcvickers
Copy link
Contributor

Just how incredibly slow does the machine have to be to go longer than 30 mins to run just this suite?!

@smitpatel
Copy link
Contributor Author

There seem to be some different issue rather than processing power. The actual run when it fails actually terminates before 10 mins passed when the test assembly started executing. SqlServer (even though running in background) still generates a lot of logs, that could also cause impact. But overall based on timestamp, something before our tests actually runs takes a lot of time randomly.

@ajcvickers
Copy link
Contributor

Windows Update on the image? :trollface:

@ajcvickers
Copy link
Contributor

Oh, this is Ubuntu. 🤦 Ubuntu update on the image?

@smitpatel
Copy link
Contributor Author

Helix runs certain things before test assembly actually starts test run. From logs it did not feel like that out tests are doing something bad so I just upped the limit for now. If this starts to be disruptive for us, I can investigate further and file an issue on arcade.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants