Throw a better exception when the model is read-only. #23888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Jan 15, 2021
| /// </summary> | ||
| protected virtual void EnsureReadonly(bool shouldBeReadonly = true) | ||
| { | ||
| if (!shouldBeReadonly && IsReadonly) |
There was a problem hiding this comment.
Shouldn't this also throw when shouldBeReadonly is true but IsReadonly is false? Or if we only use this to ensure wriability, we can just have an EnsureWritable instead (might be a good idea to have that regardless, as it's called so many times)
There was a problem hiding this comment.
I'll do the former in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15812