[5.0.x] Fix default constraint logic in SQL Server migrations (#24274) #24305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
approved these changes
Mar 1, 2021
|
Approved for April - 5.0.5. |
roji
force-pushed
the
SqlServerAlterColumn5.0
branch
from
e234d86 to
8997cd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of 6.0 fix #24274 to 5.0 release.
Fixes #24272
Description
An exception is thrown when generating migration SQL when a property is modified which has both a comment and a default value.
Customer Impact
This prevents users from generating SQL scripts or applying migrations in the scenario described above. Working around this isn't trivial.
How found
Reported by a customer.
Test coverage
Test coverage for this case has been added in this PR.
Regression?
Yes, from EF Core 3.1.
Risk
Low. SQL Server migrations are generally well-covered by tests, the fix is very small, and affects only the SQL Server migration SQL generator, which is a design-time component. The fix is also quirked.