Error for optional dependents sharing table without identifying column #24573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/validation
branch
from
f78a278 to
5ddb2aa
Compare
smitpatel
force-pushed
the
smit/validation
branch
from
5ddb2aa to
eef48fd
Compare
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
AndriySvyryd
reviewed
Apr 6, 2021
| @@ -550,6 +550,10 @@ | |||
| <value>Opening connection to database '{database}' on server '{server}'.</value> | |||
| <comment>Debug RelationalEventId.ConnectionOpening string string</comment> | |||
| </data> | |||
| <data name="LogOptionalDependentWithoutIdentifyingProperty" xml:space="preserve"> | |||
| <value>Entity type '{entityType}' is an optional dependent in table sharing without any required non shared property to identify if the entity type exist. If all nullable properties contain null value in database then an object instance won't be materialized in the query.</value> | |||
There was a problem hiding this comment.
Suggested change
| <value>Entity type '{entityType}' is an optional dependent in table sharing without any required non shared property to identify if the entity type exist. If all nullable properties contain null value in database then an object instance won't be materialized in the query.</value> | |
| <value>The entity type '{entityType}' is an optional dependent using table sharing without any required non shared property that could be used to identify whether the entity exists. If all nullable properties contain a null value in database then an object instance won't be created in the query. Add a required property to create instances with null values for other properties or mark the incoming navigation as required to always create an instance. </value> |
AndriySvyryd
reviewed
Apr 6, 2021
| @@ -550,6 +550,10 @@ | |||
| <value>Opening connection to database '{database}' on server '{server}'.</value> | |||
| <comment>Debug RelationalEventId.ConnectionOpening string string</comment> | |||
| </data> | |||
| <data name="LogOptionalDependentWithoutIdentifyingProperty" xml:space="preserve"> | |||
| <value>Entity type '{entityType}' is an optional dependent in table sharing without any required non shared property to identify if the entity type exist. If all nullable properties contain null value in database then an object instance won't be materialized in the query.</value> | |||
| <comment>Error RelationalEventId.ModelValidationOptionalDependentWithoutIdentifyingPropertyWarning string</comment> | |||
There was a problem hiding this comment.
Suggested change
| <comment>Error RelationalEventId.ModelValidationOptionalDependentWithoutIdentifyingPropertyWarning string</comment> | |
| <comment>Warning RelationalEventId.ModelValidationOptionalDependentWithoutIdentifyingPropertyWarning string</comment> |
AndriySvyryd
reviewed
Apr 6, 2021
| @@ -675,6 +679,9 @@ | |||
| <data name="NullTypeMappingInSqlTree" xml:space="preserve"> | |||
| <value>Expression '{sqlExpression}' in the SQL tree does not have a type mapping assigned.</value> | |||
| </data> | |||
| <data name="OptionalDependentWithDependentWithoutIdentifyingProperty" xml:space="preserve"> | |||
| <value>Entity type '{entityType}' is an optional dependent containing other dependents in table sharing without any required non shared property to identify if the entity type exist. If all nullable properties contain null value in database then an object instance won't be materialized in the query causing nested dependent's values to be lost.</value> | |||
There was a problem hiding this comment.
Suggested change
| <value>Entity type '{entityType}' is an optional dependent containing other dependents in table sharing without any required non shared property to identify if the entity type exist. If all nullable properties contain null value in database then an object instance won't be materialized in the query causing nested dependent's values to be lost.</value> | |
| <value>Entity type '{entityType}' is an optional dependent using table sharing and containing other dependents without any required non shared property to identify whether the entity exists. If all nullable properties contain a null value in database then an object instance won't be created in the query causing nested dependent's values to be lost. Add a required property to create instances with null values for other properties or mark the incoming navigation as required to always create an instance. </value> |
We might also need to add a fwlink
AndriySvyryd
reviewed
Apr 6, 2021
|
|
||
| VerifyError(RelationalStrings.OptionalDependentWithDependentWithoutIdentifyingProperty(nameof(A)), modelBuilder.Model); | ||
| } | ||
|
|
There was a problem hiding this comment.
Add a test for LogOptionalDependentWithoutIdentifyingProperty
AndriySvyryd
approved these changes
Apr 6, 2021
ghost
merged commit 
ajcvickers
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23229
Resolves #23198
Resolves #21488