Preview 4: Copy instead of reusing the same reference in AnnotatableBase.AddAnnotations #24781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking the commit into preview 4.
Fixes #24658
Description
An exception is thrown when generating migration SQL when a property is modified which has both a comment and a default value.
Customer Impact
The EF Core Power Tools are broken for reverse engineering/scaffolding.
How found
Reported by @ErikEJ, author of the Power Tools, while testing.
Test coverage
The fix was already in preview 5 with test coverage; this PR brings the fix and tests to preview 4.
Regression?
Yes, from preview 2.
Risk
Low. This is a feature bug fix that we are bringing forward.