Removing defensive copies #24814
Merged
Removing defensive copies #24814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling last changes
-NavigationExpandingExpressionVisitor: ToList() is not needed anymore, as we remove from IncludeTreeNode which inherites from Dictionary - TableSharingConcurrencyTokenConvention: no need for deferring removal from collection and ToList() as entityTypeDictionary is Dictionary
|
Assume you mean ToList, not ToString ? |
Yes, my bad. ToList() |
AndriySvyryd
reviewed
May 1, 2021
src/EFCore.Relational/Metadata/Conventions/TableSharingConcurrencyTokenConvention.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
May 4, 2021
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is removing some defencive ToList() which are not needed: .NET Core 3.0 added the possibility to safely remove entries from Dictionary while enumerating (dotnet/coreclr#18854).
This is for #18598
No new tests were added as all modified cases are already covered.