Add support for InfiniteTimeSpan in SetCommandTimeout.
#25085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
requested changes
Jun 13, 2021
There was a problem hiding this comment.
This change isn't correct: passing null to the overload which accepts an int? doesn't apply an infinite timeout - it applies "the default value used is defined by the underlying ADO.NET data provider" (see the XML docs there).
As per the documentation on DbCommand.CommandTimeout, for an infinite timeout we should set to 0.
src/EFCore.Relational/Extensions/RelationalDatabaseFacadeExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Shay Rojansky <roji@roji.org>
|
Requested changes done, |
|
@roji Requested changes applied. |
|
Can you please add some testing in CommandConfigurationTests.CommandTimeout? |
|
Hello @roji, Thanks for your note. Tests added and checked as successful ;) |
roji
reviewed
Jun 15, 2021
roji
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
InfiniteTimeSpanInContext.Database.SetCommandTimeout().resolves #25068 Comment 858547728