-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IServiceCollection.Use[DbProviderName]<DbContext> extension methods #25220
Conversation
Would appreciate some guidance RE testing. I wasn't able to locate any existing tests for methods similar to this so not sure if new tests are expected for thin convenience methods like this or not. |
You can add some tests to Note that we are waiting for all team members to get back to work before we review this proposal. |
What's that ETA like? |
At least two weeks |
So RC1 |
src/EFCore.SqlServer/Extensions/SqlServerServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.SqlServer/Extensions/SqlServerServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
FYI @JunTaoLuo will be taking over the task of completing this PR for rc.1 |
src/EFCore.Sqlite.Core/Extensions/SqliteServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Sqlite.Core/Extensions/SqliteServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
Flipping to ready to review to finalize the new overload signatures. I'll add tests once the API is more well defined. |
Looking good |
This is ready for final review. |
src/EFCore.SqlServer/Extensions/SqlServerServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.SqlServer/Extensions/SqlServerServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.SqlServer/Extensions/SqlServerServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Sqlite.Core/Extensions/SqliteServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Sqlite.Core/Extensions/SqliteServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Sqlite.Core/Extensions/SqliteServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
@lauxjpn ! |
Adds extension methods to enable simpler adding and configuration of contexts for a specific EF Core provider, e.g.:
Contributes to #25192
Todo: