[release/6.0-preview7] Add Migration Bundles #25256
Conversation
| } | ||
| finally | ||
| { | ||
| Directory.Delete(directory, recursive: true); |
There was a problem hiding this comment.
Handle/catch errors? https://docs.microsoft.com/en-us/dotnet/api/system.io.directory.delete?view=net-5.0
There was a problem hiding this comment.
Hmm... They all seem extremely unlikely give that we just created the directory. Worst case scenario, you get an error from the command and Disk Cleanup eventually removes it for you. Even if it errors here, you probably still got a valid bundle.
Personally, I like to handle extremely unlikely errors reactively based on feedback. This often helps me see the bigger picture so I can find the most ideal solution.
| /// </summary> | ||
| public virtual string TransformText() | ||
| { | ||
| this.Write("using System.Reflection;\r\nusing Microsoft.EntityFrameworkCore.Design;\r\n\r\nreturn M" + |
There was a problem hiding this comment.
Pretty odd place for line break 
There was a problem hiding this comment.
lol, pay no attention to the code behind the .tt curtain...
|
@smitpatel Do you intend to give approval or should somebody else from @dotnet/efteam review? |
|
I had couple of questions about how t4 working and thought of asking tomorrow during work- hours. Just realized this is for preview7 so you can merge. My questions wouldn't change anything likely. |
This commit serves as a starting point for the Migrations Bundles feature. Getting it in now will enable users to start validating it in the next preview. More refinement and automated testing to come... Part of dotnet#19693
|
Yay! |
|
lol, and I'm already finding bugs... |
This commit serves as a starting point for the Migrations Bundles feature. Getting it in now will enable users to start validating it in the next preview.
More refinement and automated testing to come...
Part of #19693