Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FromRawSql api #25457

Closed
wants to merge 1 commit into from
Closed

Add FromRawSql api #25457

wants to merge 1 commit into from

Conversation

RaymondHuy
Copy link
Contributor

@smitpatel
Copy link
Contributor

The FromSql for cosmos differs from relational implementation. The major difference comes in terms of materialization. Relational FromSql only consider the the SQL to provide data for the root entity type it is used on and all other related types must generate a join with it. Whereas in cosmos the definition should include all owned types in given type since aggregates are more general for Cosmos provider. This PR doesn't address above mismatch. Further most of the code seems replica of relational code, which may not be exact direction we need to take. (A point to remember is that, Relational is extended by other providers, Cosmos is not). Due to complexity of feature, I personally feel that this is not a feature where we can take a community contribution. The feature is planned for 6.0 release and as of now we intend to implement it but not through this PR.

@RaymondHuy - Thanks for attempt.

@smitpatel smitpatel closed this Aug 10, 2021
@roji roji mentioned this pull request Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmos: FromSql support
2 participants