Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse some IExecutionStrategy instances. #25836

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Conversation

AndriySvyryd
Copy link
Member

Don't pass null to ExecutionStrategy.ShouldRetryOn.
Use the currently executing execution strategy to determine whether buffering is needed.

Fixes #21350
Fixes #23019
Fixes #21463

@AndriySvyryd AndriySvyryd requested a review from a team September 2, 2021 04:53
Don't pass null to ExecutionStrategy.ShouldRetryOn.
Use the currently executing execution strategy to determine whether buffering is needed.

Fixes #21350
Fixes #23019
Fixes #21463
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great, thanks @AndriySvyryd!

Co-authored-by: Shay Rojansky <roji@roji.org>
@AndriySvyryd AndriySvyryd merged commit d82352e into release/6.0 Sep 3, 2021
@AndriySvyryd AndriySvyryd deleted the Issue21350 branch September 3, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants