Query: Add regression test for #23784 #25855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Sep 3, 2021
maumar
reviewed
Sep 3, 2021
| @@ -1823,6 +1823,11 @@ public override Task Regex_IsMatch_MethodCall_constant_input(bool async) | |||
| return AssertTranslationFailed(() => base.Regex_IsMatch_MethodCall_constant_input(async)); | |||
| } | |||
|
|
|||
| public override Task Datetime_subtraction_TotalDays(bool async) | |||
There was a problem hiding this comment.
do that in relational instead of individual providers?
There was a problem hiding this comment.
Depends on provider no?, npgsql can actually translate things like this using interval. cc: @roji
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23784