[6.0-rc2] Fully support int identity seed #26066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
roji/SuchASmallSeed
branch
from
88ac92c to
326fbb1
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ajcvickers
changed the title
AndriySvyryd
approved these changes
Sep 16, 2021
|
You can revert the changes from #25857 as they are redundant now. |
This reverts commit 4e68ad1.
|
@AndriySvyryd reverted. @Pilchie can we please get this into rc2? |
test/EFCore.Design.Tests/Migrations/Design/SnapshotModelProcessorTest.cs
Outdated
Show resolved
Hide resolved
|
@roji Approved by Tactics, but note that there looks like real test failures here. |
|
The change made to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26062, replaces #25857.
Description
A change in EF Core 6 to allow for long values in SQL Server identity seed values cause older int values to no longer work.
Customer Impact
Some common migrations scaffolded with earlier versions of EF Core cause errors in EF Core 6.0.
How found
Customer reports on RC1
Test coverage
Added in this PR
Regression?
Yes
Risk
Low, this simply adds support for the legacy int annotation values in two code sites.