Add a check to ShouldUseSameServiceProvider even when the extension has no options #26111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as no options Fixes #26109
|
@Pilchie For approval |
|
Good catch! |
ajcvickers
approved these changes
Sep 20, 2021
Is this the hash code of the Anyway, approved for EFCore 6.0 |
Yes
In practice, probably not. |
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26109
Description
Currently different optionless extensions return
trueinShouldUseSameServiceProviderthis could still cause a collision if the hash codes of their types happen to be the same.Customer impact
Without this an incompatible cached service provider could be resolved, causing a DI exception.
How found
PR review
Regression
No, this method is new in 6.0.
Testing
No additional tests as regression tests for this wouldn't be meaningful due to the nature of hash collisions.
Risk
Low, the new method is only used in a single place.