[6.0.1] RevEng: Consider skip navigation names when generating identifier for members of class #26531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… members of class Resolves #26496 We had mechanism to generate unique identifiers to assign to skip navigations but the code to find existing identifiers lacked skip navigations. So skip navigation names were not unique-fied throwing error when trying to add skip navigation with same name
AndriySvyryd
approved these changes
Nov 3, 2021
ajcvickers
changed the title
ajcvickers
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26496
We had mechanism to generate unique identifiers to assign to skip navigations but the code to find existing identifiers lacked skip navigations. So skip navigation names were not unique-fied throwing error when trying to add skip navigation with same name
Description
An exception is thrown when trying to scaffold model from database where a table has multiple skip navigations to different entity type but same fk properties giving same name to skip navigation.
Customer impact
A database containing such table cannot be scaffolded into model. There are no work-arounds.
How found
Customer report on nightly rtm package.
Regression
No, feature to scaffold many to many join table is new in 6.0. However, a database that could have been scaffolded previously to a model without many-to-many relationships will now cause the scaffolder to fail.
Testing
Test for this scenario added in the PR.
Risk
Low; Skip navigation names are part of identifiers and should be added to the list. Also added quirk.