[6.0.1] Avoid infinite loop when finding principal in circular relationships #26699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onships Fixes #26629 **Description** We added code in 6.0 to find the corresponding principal key property of a foreign key property when looking for value comparers. However, we missed the case where the foreign key property is itself the principal key for another overlapping relationship. This can happen when two entity types act as principal and dependents of each other, with one having a composite foreign key containing the principal key of the other. In this case, the code goes into an infinite loop. **Customer impact** Stack overflow when a model of this form is used. This is not a super common model, but is also not extremely rare, so we expect many more people to hit this as the update to 6.0. **How found** Customer reported on 6.0. **Regression** Yes, from 5.0. **Testing** Added this model to our tests. **Risk** Low; keep track of the properties we have checked so we can avoid cycles. Also added a quirk mode.
AndriySvyryd
approved these changes
Nov 15, 2021
|
when does it releases? we can't update to .net6.0 until this is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26629
Description
We added code in 6.0 to find the corresponding principal key property of a foreign key property when looking for value comparers. However, we missed the case where the foreign key property is itself the principal key for another overlapping relationship. This can happen when two entity types act as principal and dependents of each other, with one having a composite foreign key containing the principal key of the other. In this case, the code goes into an infinite loop.
Customer impact
Stack overflow when a model of this form is used. This is not a super common model, but is also not extremely rare, so we expect many more people to hit this as the update to 6.0.
How found
Customer reported on 6.0.
Regression
Yes, from 5.0.
Testing
Added this model to our tests.
Risk
Low; keep track of the properties we have checked so we can avoid cycles. Also added a quirk mode.