Suppress warnings on uninitialized DbSet properties #26795
Conversation
roji
force-pushed
the
UninitializedDbSetSuppressor
branch
from
8550edf
to
bcffe52
Compare
roji
force-pushed
the
UninitializedDbSetSuppressor
branch
from
bcffe52
to
a0b2f87
Compare
|
/cc @Youssef1313 |
| private static readonly SuppressionDescriptor _suppressUninitializedDbSetRule = new( | ||
| id: "SPR1001", | ||
| suppressedDiagnosticId: "CS8618", | ||
| justification: "DbSet properties on DbContext subclasses are automatically populated by the DbContext constructor"); |
There was a problem hiding this comment.
Is this being non-localized intentionally?
There was a problem hiding this comment.
Note that nothing else in EF Core is localized at this point.
It's true we manage exception strings via resx, but those sometimes get reused (or asserted upon in tests). I'd rather extract these strings out based on need rather than proactively, though can do that if the team prefers.
There was a problem hiding this comment.
@roji We have so far taken the approach that everything (possible) is localization ready. I'd prefer we keep doing that, but we can discuss with the team.
test/EFCore.Analyzers.Tests/UninitializedDbSetDiagnosticSuppressorTest.cs
Show resolved
Hide resolved
| static bool InheritsFrom(ITypeSymbol typeSymbol, ITypeSymbol baseTypeSymbol) | ||
| { | ||
| var baseType = typeSymbol.BaseType; | ||
| while (baseType is not null) | ||
| { | ||
| if (baseType.Equals(baseTypeSymbol, SymbolEqualityComparer.Default)) | ||
| { | ||
| return true; | ||
| } | ||
|
|
||
| baseType = baseType.BaseType; | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
Is it intentional to look at the full hierarchy, not only the parent?
There was a problem hiding this comment.
Yes - the user's DbContext type can be lower down the hierarchy, rather than directly extend DbContext. A good example is ASP.NET Identity, where user context types can extend IdentityDbContext, which itself extends DbContext. The moment DbContext is somewhere in the base type list, we know its constructor will get invoked, and therefore the DbSets will get populated.
roji
force-pushed
the
UninitializedDbSetSuppressor
branch
from
9def9d5
to
da6b358
Compare
roji
force-pushed
the
UninitializedDbSetSuppressor
branch
from
5acc0e3
to
c5f0ae7
Compare
|
@ajcvickers you may want to give my localization commit a quick look. |
Closes #21608