[6.0.2] Lift GroupByAggregate when correlation predicate matches #27108
+66
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Jan 7, 2022
Earlier, we didn't match on exact predicate Also fix bug in LikeExpression.Equals Resolves #27102
smitpatel
force-pushed
the
smit/newyearnewme
branch
from
4546961
to
490b5ea
Compare
ajcvickers
changed the title
|
Looks like there is no such thing as a "Very low" risk fix in query, see #27427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, we didn't match on exact predicate
Also fix bug in LikeExpression.Equals
Resolves #27102
Description
When projection after group by has an aggregation term which is not aggregate on grouping, incorrect SQL is generated which generates incorrect results or invalid SQL.
Customer impact
Customer queries will either give incorrect result or throw exception with invalid SQL.
How found
Customer reported on 6.0.1
Regression
Yes, From 5.0
Testing
Added test for user scenario which validates non grouping related aggregation.
Risk
Very low. Added quirk to revert to previous behavior.