[6.0.2] Bundles: Allow argument separator (--) #27128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Jan 6, 2022
ajcvickers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to set
AllowArgumentSeparator = truein the bundle's command-line parser. This subverted the remaining code I added to flow additional arguments into application code.Fixes #26945
Customer impact
Without this, it's impossible to specify application arguments from the migrations bundle. For example, to specify the ASP.NET Core environment to use when applying migrations.
Regression?
No. Migration bundles are new in EF Core 6.0.
Risk
Low. This flag only changes the behavior when specifying
--. Currently, specifying--will result in the following error.Verification
Added a unit test to ensure the flag is set.
Manually verified that arguments can now be flown into the application.