Stop prefixing check constraints. #27142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue27059
branch
from
72fca6c to
e2b7133
Compare
smitpatel
approved these changes
Jan 7, 2022
AndriySvyryd
force-pushed
the
Issue27059
branch
from
e2b7133 to
ca2eae4
Compare
AndriySvyryd
force-pushed
the
Issue27059
branch
from
ca2eae4 to
1c5f59e
Compare
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27059
Description
In 6.0 we started uniquifying check constraint names if there was a conflict in the database, but we also started adding a prefix to all names that didn't have a prefix that we recognized.
This was unexpected and unnecessary, so we decided to revert the prefixing change.
Customer impact
Users get a new migration changing all the check constraint names that don't follow the pattern. The workaround is to manually add overriding configuration for each check constraint.
How found
Customer report on 6.0.
Regression
Yes, From 5.0
Testing
Already present.
Risk
Low; only affects migrations. Also added quirk to revert to previous behavior.