Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #27138, stream with 64-bit PK #27187

Merged
2 commits merged into from
Jan 14, 2022
Merged

Conversation

cocowalla
Copy link
Contributor

Resolves an issue with blob streaming, where a 32-bit PK was always expected - but SQLite stores integers as signed, 64-bit values.

  • SqlDataRecord.GetStream changed from using GetInt32 to GetInt64
  • Added a new test

Fixes #27138

@cocowalla
Copy link
Contributor Author

@bricelam a couple of the CI jobs are failing, but it looks to be an issue with the CosmosDB emulator in the pipeline, AFAICS.

@bricelam
Copy link
Contributor

The CI has been a bit flakey. The test passed on Linux, Windows, and macOS, so I'm comfortable merging it.

@smitpatel
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@smitpatel
Copy link
Member

I am not comfortable merging on failing CI at least unless it fails on multiple attempts. We broke main branch with SqlClient upgrade by ignoring CI failure.

@bricelam
Copy link
Contributor

Rebased on main. Updated the test to cover uint values too.

@ghost
Copy link

ghost commented Jan 14, 2022

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@cocowalla
Copy link
Contributor Author

I am not comfortable merging on failing CI at least unless it fails on multiple attempts. We broke main branch with SqlClient upgrade by ignoring CI failure.

It looks like it has failed the same way on 2 attempts - I think @ajcvickers manually kicked on the 2nd rerun.

@ghost
Copy link

ghost commented Jan 14, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@bricelam
Copy link
Contributor

CI seems to be succeeding today. I bet the rebase will let it pass this time.

@bricelam
Copy link
Contributor

bricelam commented Jan 14, 2022

These integrations are possibly never going to report a check...

Wow msftbot, have you been hanging around Marvin or something?

RubbishDismissiveGIF

@ghost ghost merged commit 82a0c46 into dotnet:main Jan 14, 2022
@bricelam
Copy link
Contributor

@cocowalla Thank you for your contribution! It should be available in the daily builds soon, and in 7.0 Preview 1 whenever that ships (probably February).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqliteDataRecord.GetStream only works with 32-bit keys
3 participants