Add <inheritdoc /> in migrations #27268
Conversation
roji
force-pushed
the
MigrationsInheritDoc
branch
from
70e4b7f
to
1a947b5
Compare
roji
force-pushed
the
MigrationsInheritDoc
branch
from
1a947b5
to
c6f874d
Compare
roji
force-pushed
the
MigrationsInheritDoc
branch
from
c6f874d
to
a9d9d25
Compare
And suppress CA1814 if multidimensional seed data is present. Closes dotnet#10695
roji
force-pushed
the
MigrationsInheritDoc
branch
from
a9d9d25
to
2ea6081
Compare
| @@ -78,6 +78,14 @@ public override string Language | |||
| .AppendLine() | |||
| .AppendLine("#nullable disable"); | |||
|
|
|||
| // Suppress "Prefer jagged arrays over multidimensional" when we have a seeding operation with a multidimensional array | |||
| if (HasMultidimensionalArray(upOperations.Concat(downOperations))) | |||
There was a problem hiding this comment.
How is this related to inheritdoc?
There was a problem hiding this comment.
It isn't - it's another thing in the same area that's tracked by that same issue (see #10695 (comment)). Do you prefer I split it out, or think we shouldn't do it?
There was a problem hiding this comment.
I think we should at least discuss. I really hate adding suppressions, especially for overzealous warnings like this. Is this a modern analyzer warning? If so, what is the justification for it? If it's an old FxCop warning then...
There was a problem hiding this comment.
This rule is reported by the standard .NET analyzers that started shipping as part of the SDK in .NET 5.0 (see docs). It's indeed not enabled by default, but anyone enabling e.g. all the "performance" category diagnostics gets it.
I also hate adding suppressions, which is why I went to the extra trouble of adding it only where we actually generate a multidimensional array. I do think it reduces a bit of needless friction for users who enable most of the rules, but if you're against it we can discuss and remove.
| @@ -28,6 +28,6 @@ | |||
| <MicrosoftExtensionsLoggingVersion>7.0.0-alpha.1.22066.4</MicrosoftExtensionsLoggingVersion> | |||
| </PropertyGroup> | |||
| <PropertyGroup Label="Other dependencies"> | |||
| <MicrosoftCodeAnalysisVersion>3.7.0</MicrosoftCodeAnalysisVersion> | |||
| <MicrosoftCodeAnalysisVersion>4.0.1</MicrosoftCodeAnalysisVersion> | |||
There was a problem hiding this comment.
Can you move the following comment to here?
efcore/src/EFCore.Analyzers/EFCore.Analyzers.csproj
Lines 30 to 31 in a204b62
There was a problem hiding this comment.
Doh, I was too slow to comment; you already merged
There was a problem hiding this comment.
Oh sorry... Can slip it into the next thing (either you or me).
Any idea what 4.0.1 restricts us to in terms of VS?
There was a problem hiding this comment.
2022 (probably worth putting https://aka.ms/roslyn-packages in the comment)
And suppress CA1814 if multidimensional seed data is present.
Closes #10695