Fix for the optimizer when an entity has a collection property that references itself. #27397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eferences itself. Fixes #27301 # Conflicts: # src/EFCore.Design/Scaffolding/Internal/CSharpRuntimeModelCodeGenerator.cs
AndriySvyryd
changed the title
|
@dotnet/efteam Ping |
smitpatel
approved these changes
Feb 8, 2022
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27301
Port of #27350
Description
The code that ensures all the needed namespaces have been added recurses into generic collections, but didn't have a check for types that implent a collection of themselves.
Customer impact
Using
dotnet ef dbcontext optimizewill hang without any error messages for affected models.How found
Reported by a customer on 6.0
Regression
No. Compiled models is a new feature in 6.0
Testing
Added a test for the affected scenario.
Risk
Low. The fix is very straightforward and localized. Also, only design-time tooling is affected.