Be consistent about using ConditionalFact and ConditionalTheory

test/EFCore.Design.Tests/Migrations/Design/MigrationsBundleTest.cs

@@ -7,7 +7,7 @@ namespace Microsoft.EntityFrameworkCore.Migrations.Design;
 
 public class MigrationsBundleTest
 {
-    [Fact]
+    [ConditionalFact]
     public void Short_names_are_unique()
     {
         foreach (var command in GetCommands())
@@ -24,7 +24,7 @@ public void Short_names_are_unique()
         }
     }
 
-    [Fact]
+    [ConditionalFact]
     public void Long_names_are_unique()
     {
         foreach (var command in GetCommands())
@@ -41,7 +41,7 @@ public void Long_names_are_unique()
         }
     }
 
-    [Fact]
+    [ConditionalFact]
     public void HandleResponseFiles_is_true()
     {
         var app = new CommandLineApplication { Name = "efbundle" };
@@ -50,7 +50,7 @@ public void HandleResponseFiles_is_true()
         Assert.True(app.HandleResponseFiles);
     }
 
-    [Fact]
+    [ConditionalFact]
     public void AllowArgumentSeparator_is_true()
     {
         var app = new CommandLineApplication { Name = "efbundle" };

test/EFCore.Design.Tests/Migrations/ModelSnapshotSqlServerTest.cs

@@ -1276,7 +1276,7 @@ public virtual void Primary_key_is_stored_in_snapshot()
                 );
             });
 
-    [Fact]
+    [ConditionalFact]
     public void HasNoKey_is_handled()
         => Test(
             builder => builder.Entity<EntityWithOneProperty>().Ignore(e => e.EntityWithTwoProperties).HasNoKey(),

test/EFCore.Relational.Specification.Tests/Migrations/MigrationsTestBase.cs

@@ -935,7 +935,7 @@ public virtual Task Alter_column_remove_comment()
                 Assert.Null(column.Comment);
             });
 
-    [Fact]
+    [ConditionalFact]
     public virtual Task Alter_column_set_collation()
         => Test(
             builder => builder.Entity("People").Property<string>("Name"),
@@ -951,7 +951,7 @@ public virtual Task Alter_column_set_collation()
                 }
             });
 
-    [Fact]
+    [ConditionalFact]
     public virtual Task Alter_column_reset_collation()
         => Test(
             builder => builder.Entity("People").Property<string>("Name"),

test/EFCore.Relational.Tests/Migrations/Operations/CreateIndexOperationTest.cs

@@ -5,7 +5,7 @@ namespace Microsoft.EntityFrameworkCore.Migrations.Operations;
 
 public class CreateIndexOperationTest
 {
-    [Fact]
+    [ConditionalFact]
     public void IsDescending_count_matches_column_count()
     {
         var operation = new CreateIndexOperation();

test/EFCore.Relational.Tests/Query/Internal/QuerySqlGeneratorTest.cs

@@ -7,7 +7,7 @@ namespace Microsoft.EntityFrameworkCore.Query.Internal;
 
 public class QuerySqlGeneratorTest
 {
-    [Theory]
+    [ConditionalTheory]
     [InlineData("INSERT something")]
     [InlineData("SELECTANDSOMEOTHERSTUFF")]
     [InlineData("SELECT")]
@@ -29,7 +29,7 @@ public void CheckComposableSql_throws(string sql)
                 () => CreateDummyQuerySqlGenerator().CheckComposableSql(sql.Replace("SELECT", "WITH"))).Message);
     }
 
-    [Theory]
+    [ConditionalTheory]
     [InlineData("SELECT something")]
     [InlineData("   SELECT something")]
     [InlineData("-- comment\n SELECT something")]

test/EFCore.SqlServer.Tests/Migrations/SqlServerMigrationsAnnotationProviderTest.cs

@@ -14,7 +14,7 @@ public SqlServerMigrationsAnnotationProviderTest()
         _annotations = new SqlServerAnnotationProvider(new RelationalAnnotationProviderDependencies());
     }
 
-    [Fact]
+    [ConditionalFact]
     public void For_property_handles_identity_annotations()
     {
         var modelBuilder = SqlServerTestHelpers.Instance.CreateConventionBuilder();

test/EFCore.SqlServer.Tests/SqlServerMigrationBuilderTest.cs

@@ -5,14 +5,14 @@ namespace Microsoft.EntityFrameworkCore.SqlServer.Tests;
 
 public class SqlServerMigrationBuilderTest
 {
-    [Fact]
+    [ConditionalFact]
     public void IsSqlServer_when_using_SqlServer()
     {
         var migrationBuilder = new MigrationBuilder("Microsoft.EntityFrameworkCore.SqlServer");
         Assert.True(migrationBuilder.IsSqlServer());
     }
 
-    [Fact]
+    [ConditionalFact]
     public void Not_IsSqlServer_when_using_different_provider()
     {
         var migrationBuilder = new MigrationBuilder("Microsoft.EntityFrameworkCore.InMemory");

test/EFCore.Sqlite.Tests/Migrations/SqliteMigrationBuilderTest.cs

@@ -5,14 +5,14 @@ namespace Microsoft.EntityFrameworkCore.Migrations;
 
 public class SqliteMigrationBuilderTest
 {
-    [Fact]
+    [ConditionalFact]
     public void IsSqlite_when_using_Sqlite()
     {
         var migrationBuilder = new MigrationBuilder("Microsoft.EntityFrameworkCore.Sqlite");
         Assert.True(migrationBuilder.IsSqlite());
     }
 
-    [Fact]
+    [ConditionalFact]
     public void Not_IsSqlite_when_using_different_provider()
     {
         var migrationBuilder = new MigrationBuilder("Microsoft.EntityFrameworkCore.InMemory");

test/EFCore.Sqlite.Tests/Storage/SqliteRelationalConnectionTest.cs

@@ -7,7 +7,7 @@ namespace Microsoft.EntityFrameworkCore.Storage;
 
 public class SqliteRelationalConnectionTest
 {
-    [Fact]
+    [ConditionalFact]
     public void Sets_DefaultTimeout_when_connectionString()
     {
         var services = SqliteTestHelpers.Instance.CreateContextServices(
@@ -20,7 +20,7 @@ public void Sets_DefaultTimeout_when_connectionString()
         Assert.Equal(42, connection.DefaultTimeout);
     }
 
-    [Fact]
+    [ConditionalFact]
     public void Sets_DefaultTimeout_when_connection()
     {
         var originalConnection = new SqliteConnection("Data Source=:memory:") { DefaultTimeout = 21 };

test/EFCore.Tests/DbSetTest.cs

@@ -133,7 +133,7 @@ public void Direct_use_of_Set_throws_if_context_disposed()
             Assert.Throws<ObjectDisposedException>(() => context.Set<Category>()).Message);
     }
 
-    [Fact]
+    [ConditionalFact]
     public void Direct_use_of_Set_for_shared_type_throws_if_context_disposed()
     {
         var context = new EarlyLearningCenter();