Generate temp values for key properties contained in optional FKs #27579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't throw for unknown values that won't be sent to the database Fixes #27455
ajcvickers
approved these changes
Mar 7, 2022
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27455
Description
We stopped marking properties as store-generated when they are contained in an FK cycle to avoid stack overflows. However, this also affected cycles that contain an optional composite FK that can be used to break the cycle.
Customer impact
For models that contain an FK cycle with an optional composite FK
SaveChangeswill throw an exception when propagating the store-generated value.How found
Reported by a customer.
Regression
Yes, in 6.0.0
Testing
Added a test for the given scenario.
Risk
Low, also added a quirk mode.