Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute for configuring DeleteBehavior #27630

Merged
merged 34 commits into from
May 18, 2022
Merged

Attribute for configuring DeleteBehavior #27630

merged 34 commits into from
May 18, 2022

Commits on Mar 10, 2022

  1. Add DeleteBehaviorAttribute

    @Vekz
    Vekz committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    2929859 View commit details
    Browse the repository at this point in the history

  2. Add DeleteBehaviorAttribute Convention that sets delete behavior on f… 

    …oreign key
    @Vekz
    Vekz committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    25bf1d8 View commit details
    Browse the repository at this point in the history

  3. Register DeleteBehaviorAttributeConvention in ConventionSet provider

    @Vekz
    Vekz committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    a903461 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Add tests for DeleteBehaviorAttribute

    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    88b2376 View commit details
    Browse the repository at this point in the history

  2. Make DeleteBehaviorAttribute a property or field attribute

    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    9ac476a View commit details
    Browse the repository at this point in the history

  3. Make changes to detect added foreign key

    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    c410304 View commit details
    Browse the repository at this point in the history

  4. Add new registration in ConventionSet provider

    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    3a1693d View commit details
    Browse the repository at this point in the history

  5. Add more test cases for different edge cases

    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    6a59b7a View commit details
    Browse the repository at this point in the history

  6. Add more edge cases to tests

    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    7dc5a6f View commit details
    Browse the repository at this point in the history

  7. Add test case for implicit foreign key

    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    46d054b View commit details
    Browse the repository at this point in the history

  8. Cleanup convention and registration in provider

    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    c454830 View commit details
    Browse the repository at this point in the history

  9. Move DeleteBehavior enum and add TypeForward

    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    ac25537 View commit details
    Browse the repository at this point in the history

  10. Make DeleteBehaviorAttribute code and tests use DeleteBehavior enum

    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    e2aed9a View commit details
    Browse the repository at this point in the history

  11. Add EFCore.Abstractions assembly to fix tests after TypeForwarding De… 

    …leteBehavior enum
    @Vekz
    Vekz committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    fb34679 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Make DeleteBehaviorAttribute descriptions more meaningful

    @Vekz
    Vekz committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    c0e9b70 View commit details
    Browse the repository at this point in the history

  2. Change formatting in DeleteBehaviorAttributeConvention and fix incorr… 

    …ect class cref on convention constructor
    @Vekz
    Vekz committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    95cc27e View commit details
    Browse the repository at this point in the history

  3. Simplify test suite for DeleteBehaviorAttribute and do some minor for… 

    …matting fixes
    @Vekz
    Vekz committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    12d700e View commit details
    Browse the repository at this point in the history

  4. Make tests reflect setting the attribute on navigation property

    @Vekz
    Vekz committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    8168b9f View commit details
    Browse the repository at this point in the history

  5. Take attribute value from being set on dependent navigation property … 

    …instead of backing properties of it
    @Vekz
    Vekz committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    7e6d766 View commit details
    Browse the repository at this point in the history

  6. Limit use of the attribute to only properties to accomodate only sett… 

    …ing it on the navigation properties
    @Vekz
    Vekz committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    af2e118 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Throw InvalidOperationException when DeleteBehaviorAttribute is set o… 

    …n something different than navigation property
    @Vekz
    Vekz committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    256cb54 View commit details
    Browse the repository at this point in the history

  2. Add tests for when Attribute is set on different property than naviga… 

    …tion property
    @Vekz
    Vekz committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    599f191 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Make sure attribute is set only from dependent side

    @Vekz
    Vekz committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    4c71154 View commit details
    Browse the repository at this point in the history

  2. Make xml comments docs more readable

    @Vekz
    Vekz committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    195673a View commit details
    Browse the repository at this point in the history

  3. Simplify the convention

    @Vekz
    Vekz committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    a92c66a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Add navigation attribute convention tests and adjust code to work cor… 

    …rectly
    @Vekz
    Vekz committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5357529 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. Implement 1:1 relations delete behavior setting and restriction to th… 

    …e dependent side
    @Vekz
    Vekz committed May 15, 2022
    Configuration menu
    Copy the full SHA
    8d9d189 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Add 1:1 relationship tests and implement suggestions from PR 

    (cherry picked from commit d7ef011)
(cherry picked from commit 958f49613ac7d0ed1918620a3d6fb1b1ae81b156)
    @Vekz
    Vekz committed May 18, 2022
    Configuration menu
    Copy the full SHA
    3a1da1d View commit details
    Browse the repository at this point in the history

  2. Add stylistic changes suggested by PR and IDE

    @Vekz
    Vekz committed May 18, 2022
    Configuration menu
    Copy the full SHA
    28b09bb View commit details
    Browse the repository at this point in the history

  3. Fix CoreStrings.resx merge conflicts

    @Vekz
    Vekz committed May 18, 2022
    Configuration menu
    Copy the full SHA
    665fdd8 View commit details
    Browse the repository at this point in the history

  4. Fix CoreStrings.resx merge conflicts

    @Vekz
    Vekz committed May 18, 2022
    Configuration menu
    Copy the full SHA
    02860a3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into 9621_DeleteBehaviorAttribute

    @Vekz
    Vekz authored May 18, 2022
    Configuration menu
    Copy the full SHA
    0460b8a View commit details
    Browse the repository at this point in the history

  6. Run Custom Tool on CoreStrings.Designer.tt

    @Vekz
    Vekz committed May 18, 2022
    Configuration menu
    Copy the full SHA
    6fc84c1 View commit details
    Browse the repository at this point in the history

  7. Add virtual modifier to the DeleteBehaviorAttributeConvention's publi… 

    …c APIs
    @Vekz
    Vekz committed May 18, 2022
    Configuration menu
    Copy the full SHA
    4cb7491 View commit details
    Browse the repository at this point in the history