Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure FK properties have nullable-appropriate value comparers #27654

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Ensure FK properties have nullable-appropriate value comparers #27654

merged 1 commit into from
Mar 17, 2022

Commits on Mar 16, 2022

  1. Ensure FK properties have nullable-appropriate value comparers 

    Part of #11597

This change takes the ValueComparer defined for the principal key and uses it for the foreign key, but also accommodating for nulls appropriately. As part of this, we started getting some more complex expressions in value comparers used in the in-memory database. These expressions became part of the query, which then meant they needed to be translated. Therefore, this logic has been changed to call the value comparer as a method when using the in-memory database, and this method is then detected. This incidentally fixes #27495, which was also a case of a value comparer expression that could not be translated, and any other case where a value comparer could not be translated in in-memory queries.
    @ajcvickers
    ajcvickers committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    8e23bfb View commit details
    Browse the repository at this point in the history