Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Query: Assign proper type to collection result expression (part 2) #27664

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[release/6.0] Query: Assign proper type to collection result expression (part 2) #27664

merged 1 commit into from
Apr 5, 2022

Commits on Mar 17, 2022

  1. Query: Assign proper type to collection result expression (part 2) 

    This improves the fix made in #27134

In earlier PR we converted `IQueryable<T>` to `IEnumerable<T>` becaused we converted enumerable to queryable during preprocessing phase and types aligned in later phase since we create a list (which does implement `IEnumerable<T>`). Though this implementing behavior doesn't work when returning a single result of enumerable during async which wraps collection type inside Task.
The better fix is to assign `List<T>` as type since we are eventually creating a list.
In case of single result, the single result operator has generic type which will introduce convert node into it automatically which will match types for async tasks.

Resolves #27600
    @smitpatel
    smitpatel committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    0db9e7a View commit details
    Browse the repository at this point in the history