Support value generation for converted types #27759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
reviewed
Apr 6, 2022
ilmax
reviewed
Apr 6, 2022
| /// <param name="clrType">X</param> | ||
| /// <returns>X</returns> | ||
| protected virtual ValueGenerator? FindForType(IProperty property, IEntityType entityType, Type clrType) | ||
| => clrType == typeof(Guid) |
There was a problem hiding this comment.
nit: a switch may be a bit more readable
Providers may need to be updated to support this. Fixes #11597
ajcvickers
force-pushed
the
SevenNationArmy0307
branch
from
1baf270
to
b2a580f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providers may need to be updated to support this.
Fixes #11597