Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop validating non-null/empty connection strings #27874

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

ajcvickers
Copy link
Member

Instead, let ADO.NET validate. This allows the connection string to be set as late as possible, for example in the ConnectionOpening interceptor.

Fixes #23085

@ajcvickers ajcvickers requested a review from a team April 23, 2022 18:56
Instead, let ADO.NET validate. This allows the connection string to be set as late as possible, for example in the ConnectionOpening interceptor.

Fixes #23085
@ajcvickers ajcvickers force-pushed the SomehowTheVitalConnectionIsMade0421 branch from 7c1ad4d to bcb2310 Compare April 25, 2022 09:05
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the exception that you get from ADO.NET?

@ajcvickers
Copy link
Member Author

@AndriySvyryd System.InvalidOperationException: The ConnectionString property has not been initialized.

@ajcvickers ajcvickers merged commit 54f5571 into main Apr 25, 2022
@ajcvickers ajcvickers deleted the SomehowTheVitalConnectionIsMade0421 branch April 25, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't check for a connection string until after ConnectionOpening has been called
2 participants