Query: Add support for TPC #27961
Merged
Query: Add support for TPC #27961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
commented
May 6, 2022
src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
May 6, 2022
...l/Query/RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
May 6, 2022
src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
May 6, 2022
maumar
reviewed
May 6, 2022
maumar
reviewed
May 6, 2022
Part of #3170
maumar
reviewed
May 6, 2022
| select1._projection.Select(p => | ||
| new ProjectionExpression(new ConcreteColumnExpression(p, tableReferenceExpression), p.Alias))); | ||
| subSelectExpressions.Enqueue(selectExpression); | ||
| count -= 2; |
There was a problem hiding this comment.
this can go below 0, we need to reset the count after we perform each full pass of "unionization"
|
general observation: given the (current) complex logic in building the union structure, we should add some tests with deep inheritance hierarchies. No need for complex queries on those just make sure that This can be done is a separate pr. |
maumar
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3170