Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalize database name #27966

Merged
merged 3 commits into from
May 18, 2022
Merged

Capitalize database name #27966

merged 3 commits into from
May 18, 2022

Conversation

ilmalte
Copy link
Contributor

@ilmalte ilmalte commented May 6, 2022 •
edited
Loading

  • When scaffolding from a database the database name is modified in order to respect .NET conventions

Fixes #27886

@ilmalte
Capitalize database name
24364e3 
- When scaffolding from a database the database name is modified in order to respect .NET conventions

#Fixes 27886
@dnfadmin
Copy link

dnfadmin commented May 6, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@bricelam bricelam self-assigned this May 11, 2022
@ilmalte
Capitalize database name
9d458f8 
- When scaffolding from a database the database name is modified in order to respect .NET conventions

#Fixes 27886
@ilmalte
Capitalize database name
0cdf433 
- When scaffolding from a database the database name is modified in order to respect .NET conventions

#Fixes 27886
bricelam
bricelam approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost
Copy link

ghost commented May 18, 2022

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@bricelam bricelam merged commit 5a759d5 into dotnet:main May 18, 2022
@bricelam
Copy link
Contributor

Thanks @ilmalte (and @vanillajonathan)! This behavior was a pet peeve of mine, so I really appreciate it.

@ajcvickers ajcvickers mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikEJ ErikEJ ErikEJ left review comments

@bricelam bricelam bricelam approved these changes

Assignees

@bricelam bricelam

Labels
auto-merge community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pascal-case the DbContext name when scaffolding
4 participants
@ilmalte @dnfadmin @bricelam @ErikEJ