Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Infer type mapping from IDbFunction while translating #27995

Merged
merged 1 commit into from
May 11, 2022
Merged

Query: Infer type mapping from IDbFunction while translating #27995

merged 1 commit into from
May 11, 2022

Conversation

smitpatel
Copy link
Contributor

@smitpatel smitpatel commented May 10, 2022 •
edited
Loading

  • We use TypeMapping if configured on the DbFunction, or
  • We try to get it if store type is specified
  • If neither of above work then we do the default type mapping based on return type

Resolves #27954
Resolves #27524

@smitpatel smitpatel changed the title Query: Configure and use TypeMapping on DbFunction Query: Infer type mapping from IDbFunction while translating May 11, 2022
@smitpatel smitpatel merged commit f6988cd into main May 11, 2022
@smitpatel smitpatel deleted the smit/issue27954 branch May 11, 2022 21:04
roji
roji reviewed May 16, 2022
View reviewed changes
test/EFCore.Relational.Specification.Tests/Query/SimpleQueryRelationalTestBase.cs
modelBuilder
.HasDbFunction(typeof(MyEntity).GetMethod(nameof(MyEntity.Modify)))
.HasName("ModifyDate")
.HasStoreType("datetime")
Copy link
Member

@roji roji May 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😿

Not easy to override this for databases which don't have a datetime store type... In any case, this test seems a bit SQL Server-specific, do we want to move it there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HasStoreType(null) should work

@ajcvickers ajcvickers mentioned this pull request May 26, 2022
Closed
smitpatel added a commit that referenced this pull request Sep 27, 2022
@smitpatel
Query: Use type mapping from IDbFunction while translating (#27995)
437b504 
Resolves #27954
Resolves #27524
Resolves #29204
ajcvickers pushed a commit that referenced this pull request Nov 2, 2022
@smitpatel
[release/6.0] Query: Use type mapping from IDbFunction while translat…
03ef186 
…ing (#27995) (#29216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@roji roji roji left review comments

@maumar maumar Awaiting requested review from maumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function StoreType is ignored for DateTime RelationalMethodCallTranslatorProvider and explicit typeMapping
3 participants
@smitpatel @roji @AndriySvyryd