Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for System.Text.Json not including LazyLoader #28084

Merged

Conversation

EfimenkoAndrew
Copy link
Contributor

  • [ + ] I've read the guidelines for contributing and seen the walkthrough
  • [ + ] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • [ + ] The code builds and tests pass locally (also verified by our automated build checks)
  • [ + ] Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • [ - ] Tests for the changes have been added (for bug fixes / features) I do not know how to test attribute, i am sorry, i am stupid
  • [ + ] Code follows the same patterns and style as existing code in this repo

Related issue #28083

        - add support for System.Text.Json not including LazyLoader
Fixes dotnet#28083
@EfimenkoAndrew EfimenkoAndrew force-pushed the feature/fix-json-serialisation branch from 7cdee75 to a47b595 Compare May 23, 2022 15:28
@EfimenkoAndrew
Copy link
Contributor Author

Hi
if it ever gonna be reviewed and merged please add the fix to the .net 6 version of library

@ajcvickers ajcvickers merged commit 8a6370f into dotnet:main May 26, 2022
@ajcvickers
Copy link
Member

@EfimenkoAndrew Thanks for the contribution.

please add the fix to the .net 6 version of library

It's unlikely that we will patch EF Core 6.0 for this. See the release planning process for information on how we decide what to patch.

@ajcvickers ajcvickers changed the title add support for System.Text.Json not including LazyLoader Add support for System.Text.Json not including LazyLoader Jun 9, 2022
@Grauenwolf
Copy link

Would it have been better to convince the System.Text.Json team to just honor IgnoreDataMember?

@roji
Copy link
Member

roji commented Jun 17, 2022

The decision in dotnet/runtime#29975 seems pretty clear/final, and in any case, just adding a [JsonIgnore] doesn't really have any drawbacks...

@Grauenwolf
Copy link

Did EF Core already have a dependency on System.Text.Json.Serialization? I ask because that sounds like an odd dependency for an ORM.

@ajcvickers
Copy link
Member

@Grauenwolf It's in the BCL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants