[release/6.0] Query: Don't add grouping key to projection when Distinct is applied #28143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ping all. The release/6.0 branch is open for 6.0.7 changes but this PR is neither servicing-approved nor approved. Thanks… |
maumar
approved these changes
Jun 7, 2022
|
Please add a comment when this gets |
ajcvickers
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28039
Description
If we need to push current query into a subquery when query has group by operation, we add grouping key to projection so we can refer to them outside but that is incorrect if distinct is applied on the projection since it would change meaning of distinct.
Customer impact
Customers running query which are affected by scenario will get incorrect results.
How found
Customer reported on 6.0.5
Regression
Yes as reported by customer, it worked on 5.0.13
Testing
Added tests for affected scenario.
Risk
Low. Also added quirk to revert back to older behavior.