Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CSharpHelper for Dictionary literals #28330

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

yinzara
Copy link
Contributor

@yinzara yinzara commented Jun 27, 2022

Fixes #19274

[X] I've read the guidelines for contributing and seen the walkthrough
[X] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
[X] The code builds and tests pass locally (also verified by our automated build checks)
Commit messages follow this format:
Summary of the changes
- Detail 1
- Detail 2

    Fixes #bugnumber

[X] Tests for the changes have been added (for bug fixes / features)
[X] Code follows the same patterns and style as existing code in this repo

@yinzara yinzara force-pushed the feature/19274-dictionary branch 5 times, most recently from 72618d5 to e314e5b Compare June 29, 2022 20:57
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinzara
Copy link
Contributor Author

yinzara commented Jul 9, 2022

All comments should have been addressed. TY

@yinzara
Copy link
Contributor Author

yinzara commented Aug 16, 2022

Any reason this isn't getting merged? @bricelam

@bricelam bricelam changed the base branch from main to release/7.0 August 16, 2022 17:54
@ghost
Copy link

ghost commented Aug 16, 2022

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 16, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost
Copy link

ghost commented Aug 16, 2022

Apologies, while this PR appears ready to be merged, it looks like release/7.0 is a protected branch and I have not been granted permission to perform the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSharpHelper: support more types of collection literals
4 participants