Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra duplicate migration existence check #28454

Merged
merged 1 commit into from
Jul 30, 2022
Merged

remove extra duplicate migration existence check #28454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/EFCore.Design/Migrations/Design/MigrationsScaffolder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ public virtual ScaffoldedMigration ScaffoldMigration(
string? subNamespace = null,
string? language = null)
{
if (string.Equals(migrationName, "migration", StringComparison.OrdinalIgnoreCase))
{
throw new OperationException(DesignStrings.CircularBaseClassDependency);
}

if (Dependencies.MigrationsAssembly.FindMigrationId(migrationName) != null)
{
throw new OperationException(DesignStrings.DuplicateMigrationName(migrationName));
Expand All @@ -80,16 +85,6 @@ public virtual ScaffoldedMigration ScaffoldMigration(
subNamespaceDefaulted = true;
subNamespace = "Migrations";
}

if (string.Equals(migrationName, "migration", StringComparison.OrdinalIgnoreCase))
{
throw new OperationException(DesignStrings.CircularBaseClassDependency);
}

if (Dependencies.MigrationsAssembly.FindMigrationId(migrationName) != null)
MoienTajik marked this conversation as resolved.
Show resolved Hide resolved
{
throw new OperationException(DesignStrings.DuplicateMigrationName(migrationName));
}

var (key, typeInfo) = Dependencies.MigrationsAssembly.Migrations.LastOrDefault();

Expand Down