Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null connection string to be passed to UseProvider methods #28460

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Allow null connection string to be passed to UseProvider methods #28460

merged 1 commit into from
Jul 16, 2022

Conversation

ajcvickers
Copy link
Member

Fixes #26869

@ajcvickers ajcvickers requested a review from a team July 15, 2022 15:53
@ajcvickers
Copy link
Member Author

/cc @roji @lauxjpn

roji
roji approved these changes Jul 16, 2022
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though out of curiosity, is there any specific user scenario which requires this?

@roji roji mentioned this pull request Jul 16, 2022
Closed
@ajcvickers
Copy link
Member Author

Yes: Running a bundle passing the connection string when there is no connection string in the config. It's in the issue.

@ajcvickers ajcvickers merged commit 5abbef9 into main Jul 16, 2022
@ajcvickers ajcvickers deleted the NullForNoobs0715 branch July 16, 2022 12:14
@ajcvickers ajcvickers mentioned this pull request Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
providers-beware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow null connection string to be passed to UseProvider methods
2 participants
@ajcvickers @roji